Add javadoc to generated gRPC service class public API#3
Merged
Conversation
Generated gRPC service classes (e.g., TestServiceGrpc) now have javadoc on all public methods and inner types: - Class-level: uses proto service comment (already present) - getXxxMethod(): uses proto method doc or default description - newStub() / newBlockingStub(): factory method descriptions - getServiceDescriptor() / bindService(): utility descriptions - AsyncService, ImplBase, Stub, BlockingStub: class-level docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add javadoc comments to all public methods and inner types in generated gRPC service classes.
Changes
Single file:
LightProtoService.javaJavadoc added to:
getXxxMethod()descriptor getters - uses proto method doc when available, otherwise a default descriptionnewStub()/newBlockingStub()factory methodsgetServiceDescriptor()/bindService()utility methodsAsyncServiceinterface,ImplBaseabstract class,StubandBlockingStubinner classesTest plan
TestServiceGrpc.javahas javadoc on every public method and type